find: parse ISO 8601 dates in -newerXt to match GNU - #847
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 92.27% 92.29% +0.01%
==========================================
Files 35 35
Lines 7435 7445 +10
Branches 386 388 +2
==========================================
+ Hits 6861 6871 +10
Misses 433 433
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit 8f47f33 has test result changes: bfs testsuite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
findaccepts ISO 8601 dates as the reference time for the-newerXtpredicates (-newermt,-newerat,-newerct):uutils only accepted its own
Mon DD, YYYY [HH:MM:SS]form and errored on the ISO form:This adds the two ISO shapes (a plain date, and a date with time) to
parse_date_str_to_timestamps, tried before the existing regex, so the current formats are unchanged. The scope is deliberately just ISO 8601, the most common unambiguous case; other GNU date forms can follow later.Tested: unit assertions for both ISO shapes, and the
-newerXtintegration test now also runs the ISO inputs.cargo fmtandcargo clippyare clean.